Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where some options were missing in the Google Drive context menu #12935

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 12, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Google Drive offline access option missing in context menu #12912

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Install google drive and verify that all items appear in context menu
    2. Verify that Files does not crash when right clicking an exe and you have an NVidia graphic card

Screenshots (optional)
image

@yaira2 yaira2 changed the title Fix: Fixed missing items in Google Drive context menu Fix: Fixed issue where some items were missing in the Google Drive context menu Jul 12, 2023
@yaira2 yaira2 changed the title Fix: Fixed issue where some items were missing in the Google Drive context menu Fix: Fixed issue where some options were missing in the Google Drive context menu Jul 12, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 84a62bb into files-community:main Jul 12, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 12, 2023
@gave92 gave92 deleted the issue_12912 branch July 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Google Drive offline access option missing in context menu
2 participants