Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where Status Center didn't update when archives were finished being extracted #12838

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Status center doesn't indicate when archive is decompressed #12809

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select a small archive (extraction should take less than 6 seconds)
    2. Extract it
    3. Check the status center
    4. Repeat using a big archive (extraction time >= 6s)

@yaira2 yaira2 changed the title Fix: Status center doesn't indicate when archive is decompressed Fix: Fixed issue where Status Center didn't update when archives were finished being extracted Jul 3, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 3, 2023
@yaira2 yaira2 merged commit 3e553a6 into files-community:main Jul 3, 2023
@ferrariofilippo ferrariofilippo deleted the Fix_Extraction_Status_Banner branch July 3, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Status center doesn't indicate when archive is decompressed
2 participants