Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated font colors in the Properties window #12795

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 29, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open properties window
    2. Confirm the property names have the correct font color

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 29, 2023
@yaira2 yaira2 merged commit 0ce82c6 into main Jun 29, 2023
@yaira2 yaira2 deleted the ya/PropertiesStyle branch June 29, 2023 22:58
Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things

@@ -23,6 +23,8 @@
<Style x:Key="PropertyName" TargetType="TextBlock">
<Setter Property="Margin" Value="{StaticResource PropertyNameMargin}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You kept these margins. I probably would have removed them. Are they really needed?

@@ -142,7 +146,7 @@
<!-- Algorithm Name -->
<TextBlock
VerticalAlignment="Center"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Alignment Issue in Properties - "Type" and "File System" Misalignment
2 participants