Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where the System version of VS Code wasn't detected #12750

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Fix: Fixed issue where the System version of VS Code wasn't detected #12750

merged 5 commits into from
Jun 29, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Install VS Code (System)
    2. Navigate to a git repository

@yaira2 yaira2 changed the title Fix: Visual Studio Code (System) is not detected Fix: Fixed issue where System version of Visual Studio Code wasn't detected Jun 26, 2023
marcofranzen99
marcofranzen99 reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@marcofranzen99 marcofranzen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes, works as expected, Open in VS code is now displayed

src/Files.App/Helpers/SoftwareHelpers.cs Outdated Show resolved Hide resolved
@yaira2 yaira2 requested a review from QuaintMako June 29, 2023 02:56
QuaintMako
QuaintMako approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise, I cannot test it for now though.

@yaira2 yaira2 changed the title Fix: Fixed issue where System version of Visual Studio Code wasn't detected Fix: Fixed issue where the System version of Visual Studio Code wasn't detected Jun 29, 2023
@yaira2 yaira2 changed the title Fix: Fixed issue where the System version of Visual Studio Code wasn't detected Fix: Fixed issue where the System version of VS Code wasn't detected Jun 29, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 29, 2023
@yaira2 yaira2 merged commit b3736d8 into files-community:main Jun 29, 2023
@ferrariofilippo ferrariofilippo deleted the Detect_System_VSCode branch June 30, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcofranzen99 marcofranzen99 marcofranzen99 left review comments

@QuaintMako QuaintMako QuaintMako approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferrariofilippo @marcofranzen99 @QuaintMako @yaira2