Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash with moving into an empty folder in column layout #12725

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select an empty folder in column layout
    2. Press right arrow key
    3. Files doesn't crash

@hishitetsu hishitetsu changed the title Fix: Fixed crash with move into an empty folder in column layout Fix: Fixed crash with moving into an empty folder in column layout Jun 25, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 25, 2023
@yaira2 yaira2 merged commit ee54f83 into files-community:main Jun 25, 2023
@hishitetsu hishitetsu deleted the FixCrashInColumnLayout branch June 25, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: To entry in any empty folder with arrow keys in Column Layout crash Files
2 participants