Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Auto-Populate Files and Windows Version when submitting feedback #12639

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

tanchekwei
Copy link
Contributor

@tanchekwei tanchekwei commented Jun 17, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Attach version info when submitting issues reports #4635

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Comment

Add files_version and windows_version query string to BugReportUrl or FeatureRequestUrl when user click on Submit Feature / Bug Request so that issue form able to auto populate their value to the form element with same id defined in bug_report.yml and feature_request.yml

Documentation reference: Syntax for GitHub's form schema (Keys section)

To test this functionality, please use the test-issue-4635 branch, as I have updated the template URL to point to my repository's branch in commit ef0b49235fc48e459b818b28b6addae1b653f9fd.

Screenshots (optional)

2023-06-17.15-39-25-1.mp4

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Auto-Populate Files and Windows Version on Issue Page Feature: Auto-Populate Files and Windows Version when submitting feedback Jun 19, 2023
@yaira2 yaira2 assigned yaira2 and unassigned yaira2 Jun 19, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 19, 2023
@yaira2 yaira2 merged commit 3984d73 into files-community:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Attach version info when submitting issues reports
3 participants