Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added support for pushing Git commits #12633

Merged
merged 29 commits into from
Jun 28, 2023
Merged

Feature: Added support for pushing Git commits #12633

merged 29 commits into from
Jun 28, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Support for pushing git changes #12561

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Can't be tested at the moment

@ferrariofilippo ferrariofilippo marked this pull request as draft June 16, 2023 19:18
@ferrariofilippo ferrariofilippo marked this pull request as ready for review June 16, 2023 19:25
@ferrariofilippo
Copy link
Contributor Author

I think we should find a way to test this before merging

@yaira2
Copy link
Member

yaira2 commented Jun 18, 2023

Does this help for pulling from private repos?

@ferrariofilippo
Copy link
Contributor Author

Does this help for pulling from private repos?

I'll add that

@yaira2 yaira2 changed the title Feature: Support git push Feature: Added support for pushing commits Jun 20, 2023
@yaira2 yaira2 requested a review from heftymouse June 26, 2023 17:03
@yaira2 yaira2 changed the title Feature: Added support for pushing commits Feature: Added support for pushing Git commits Jun 26, 2023
QuaintMako
QuaintMako reviewed Jun 27, 2023
View reviewed changes
src/Files.App/Actions/Git/GitPushAction.cs Show resolved Hide resolved
src/Files.App/Actions/Git/GitSyncAction.cs Outdated Show resolved Hide resolved
src/Files.App/Helpers/GitHelpers.cs Outdated Show resolved Hide resolved
src/Files.App/Helpers/GitHelpers.cs Outdated Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved
yaira2
yaira2 previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from QuaintMako June 27, 2023 20:00
@ferrariofilippo
Copy link
Contributor Author

@yaira2 if you or anyone else wants to test I created an OAuth app, write me on DS and I'll give you the name and client id

QuaintMako
QuaintMako approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 7b463ec into files-community:main Jun 28, 2023
@yaira2
Copy link
Member

yaira2 commented Jun 28, 2023

@ferrariofilippo thank you for all your hard work on this feature.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 28, 2023
@ferrariofilippo ferrariofilippo deleted the Git_Push branch June 28, 2023 05:56
yaira2
yaira2 reviewed Jun 29, 2023
View reviewed changes
src/Files.App/Dialogs/GitHubLoginDialog.xaml
<RowDefinition />
</Grid.RowDefinitions>

<StackPanel Width="360" Height="40">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to Border?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #12793

yaira2
yaira2 reviewed Jun 29, 2023
View reviewed changes
src/Files.App/Strings/en-US/Resources.resw
@@ -3344,4 +3371,7 @@
<data name="UnableToDisplayOwner" xml:space="preserve">
<value>Unable to display current owner.</value>
</data>
<data name="AuthorizationSucceded">
<value>Great! You are now authorised.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*authorized

@ferrariofilippo ferrariofilippo mentioned this pull request Jun 29, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@QuaintMako QuaintMako QuaintMako approved these changes

@0x5bfa 0x5bfa Awaiting requested review from 0x5bfa

@heftymouse heftymouse Awaiting requested review from heftymouse

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support for pushing git changes
4 participants
@ferrariofilippo @yaira2 @heftymouse @QuaintMako