Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Cleaned up Files.Backend #12631

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Code Quality: Cleaned up Files.Backend #12631

merged 10 commits into from
Jun 20, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 16, 2023

Code Quality: Clean up Files.Backend phase 1

Motivation & Context

  • Improved readability

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code Quality: Continued work to clean up entire project #12340
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

ferrariofilippo
ferrariofilippo approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 19, 2023

@yaira2 Can you review again?

@yaira2
Copy link
Member

yaira2 commented Jun 19, 2023

Ready for the next commit

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 20, 2023

I wanna split up. So that was last commit I suppose.

@yaira2 yaira2 changed the title Code Quality: Clean up Files.Backend phase 1 Code Quality: Cleaned up Files.Backend Jun 20, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 20, 2023
@yaira2 yaira2 merged commit 2fabe0f into files-community:main Jun 20, 2023
@0x5bfa 0x5bfa deleted the 5bfa/cleanup-backend branch July 6, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @yaira2 @ferrariofilippo