Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where navigating away from search wouldn't show the folders items #12628

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Folder is empty after canceling a search #12612

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 changed the title Fix: Fixed issue with no items found when navigating during a search Fix: Fixed issue where navigating away from search wouldn't show the folders items Jun 16, 2023
@hishitetsu hishitetsu marked this pull request as draft June 17, 2023 00:57
@hishitetsu
Copy link
Member Author

Now I know why the pipeline fails to test. It needs to be fixed.

@hishitetsu hishitetsu marked this pull request as ready for review June 17, 2023 01:18
@hishitetsu
Copy link
Member Author

It should be fixed now.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 19, 2023
@yaira2 yaira2 merged commit d2a4a0b into files-community:main Jun 19, 2023
@hishitetsu hishitetsu deleted the NavigationDuringSearch branch June 19, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folder is empty after canceling a search
2 participants