Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated the fallback color for Acrylic #12625

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

heftymouse
Copy link
Contributor

@heftymouse heftymouse commented Jun 15, 2023

This PR changes the Acrylic fallback colour on dark mode to #202020 which is a much more pleasing colour also used by Mica.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member

yaira2 commented Jun 15, 2023

It also changes the sidebar and top bar border to use the divider stroke brush making it more consistent.

Can you separate this change? It needs to be discussed with design and I don't want to hold back the other improvements.

@heftymouse heftymouse changed the title Feature: Improve the appearance of Acrylic Feature: Change Acrylic fallback colour on dark mode Jun 15, 2023
@yaira2 yaira2 requested a review from 0x5bfa June 16, 2023 14:42
yaira2
yaira2 previously approved these changes Jun 16, 2023
src/Files.App/Helpers/AppSystemBackdrop.cs Outdated Show resolved Hide resolved
@heftymouse heftymouse requested a review from yaira2 June 17, 2023 08:40
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 18, 2023
@yaira2 yaira2 changed the title Feature: Change Acrylic fallback colour on dark mode Feature: Updated the fallback color for Acrylic Jun 18, 2023
@yaira2 yaira2 merged commit 2f536a3 into files-community:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants