Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash when changing tab with one git repository open #12575

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Issue reported on Discord

Details

  • The issue was caused by the Locals radio button which was unchecked when changing tab, causing the app to try to checkout a branch on load

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a git repository in one tab
    2. Open another tab
    3. Switch back to the first tab

@yaira2 yaira2 merged commit 1fcbe14 into files-community:main Jun 9, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 9, 2023
@ferrariofilippo ferrariofilippo deleted the Bug_Tabs_Git_Crash branch June 9, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants