-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue where custom font wasn't applied to the details pane #12554
Merged
yaira2
merged 8 commits into
files-community:main
from
QuaintMako:120207_CustomFontMissing
Jun 8, 2023
Merged
Fix: Fixed issue where custom font wasn't applied to the details pane #12554
yaira2
merged 8 commits into
files-community:main
from
QuaintMako:120207_CustomFontMissing
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-o-Way
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always good to not-hardcode :-)
yaira2
reviewed
Jun 6, 2023
yaira2
reviewed
Jun 6, 2023
yaira2
changed the title
Using custom font in preview pane + small clean
Fix: Fixed issue where custom font wasn't applied to the details pane
Jun 6, 2023
yaira2
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: Custom font not used in item preview pane #12027
Validation
How did you test these changes?
Screenshots