Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue with selecting multiple items in column layout #12515

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Items from multiple columns are selected #12429...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Switch to column layout
    2. Open a folder from the second column
    3. Select al the items in the second column and verify that the third column is closed

Screenshots (optional)
Add screenshots here.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column disappears when the second file is selected, which is an odd behavior.

2023-06-01.103009.mp4

@yaira2
Copy link
Member Author

yaira2 commented Jun 1, 2023

The column disappears when the second file is selected, which is an odd behavior.

Can you confirm if this is fixed now?

@hishitetsu
Copy link
Member

The column disappears when the second file is selected, which is an odd behavior.

Can you confirm if this is fixed now?

This causes crashes.

image

@yaira2
Copy link
Member Author

yaira2 commented Jun 1, 2023

I can't reproduce this issue but perhaps it can be fixed by moving the if statement earlier.

@hishitetsu
Copy link
Member

I can't reproduce this issue but perhaps it can be fixed by moving the if statement earlier.

2023-06-01.105112.mp4

@yaira2 yaira2 requested a review from hishitetsu June 1, 2023 14:41
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't crash and it is better than before, but there are still some suspicious behaviors.

2023-06-02.000055.mp4

@yaira2
Copy link
Member Author

yaira2 commented Jun 1, 2023

It doesn't crash and it is better than before, but there are still some suspicious behaviors.

I noticed this as well, but I didn't find an easy fix. If you're okay with it, we should merge this PR and try to fix that separately.

@hishitetsu
Copy link
Member

It doesn't crash and it is better than before, but there are still some suspicious behaviors.

I noticed this as well, but I didn't find an easy fix. If you're okay with it, we should merge this PR and try to fix that separately.

Yes, I think that is fine too.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 1, 2023
@yaira2 yaira2 merged commit 17a3d30 into main Jun 1, 2023
@yaira2 yaira2 deleted the ya/FixColumnSelection branch June 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Items from multiple columns are selected
2 participants