-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue with selecting multiple items in column layout #12515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column disappears when the second file is selected, which is an odd behavior.
2023-06-01.103009.mp4
Can you confirm if this is fixed now? |
I can't reproduce this issue but perhaps it can be fixed by moving the if statement earlier. |
2023-06-01.105112.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't crash and it is better than before, but there are still some suspicious behaviors.
2023-06-02.000055.mp4
I noticed this as well, but I didn't find an easy fix. If you're okay with it, we should merge this PR and try to fix that separately. |
Yes, I think that is fine too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Closes Bug: Items from multiple columns are selected #12429...
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.