Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where renaming folder in the columns layout would open the folder #12498

Merged
merged 2 commits into from
May 31, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 31, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Switch to column layout
    2. Rename folder and verify the folder doesn't keep opening and closing as you enter the name

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Fixed issue where renaming folder in the column layout would open the folder Fix: Fixed issue where renaming folder in the columns layout would open the folder May 31, 2023
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 31, 2023
@yaira2 yaira2 merged commit 1ba8517 into main May 31, 2023
@yaira2 yaira2 deleted the ya/RenameColumns branch May 31, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Renaming folders in columns layout sometimes opens the folder
2 participants