Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show a tooltip when a text in the details view is trimmed #12488

Merged
merged 2 commits into from
May 31, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Re-add tooltip to details layout #12481

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. When a text in the details view is trimmed, a tooltip will be displayed when hovering.
    2. When a text in the details view is not trimmed, a tooltip will not be displayed.

Screenshots
image

@yaira2
Copy link
Member

yaira2 commented May 30, 2023

Thank you for the PR, do you know if this affects performance?

@hishitetsu
Copy link
Member Author

Thank you for the PR, do you know if this affects performance?

I tested a folder contains 3,000 files. I did not notice any particular performance degradation when changing column widths, so I think it should be fine.

@yaira2
Copy link
Member

yaira2 commented May 30, 2023

I'm more concerned about larger directories (40k items)

@hishitetsu
Copy link
Member Author

I'm more concerned about larger directories (40k items)

At least in my environment, there seems to be no performance impact even with 40k files.

@yaira2
Copy link
Member

yaira2 commented May 30, 2023

I found this feature request on the WinUI repo microsoft/microsoft-ui-xaml#170

@yaira2 yaira2 requested review from yaira2 and removed request for marcelwgn May 30, 2023 16:31
@yaira2 yaira2 self-assigned this May 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 31, 2023
@yaira2 yaira2 merged commit eb38f9e into files-community:main May 31, 2023
@hishitetsu hishitetsu deleted the ShowToolTipForTrimmedText branch May 31, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Re-add tooltip to details layout
3 participants