Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added support for displaying and editing metadata of multiple files #12476

Merged
merged 9 commits into from
May 30, 2023
Merged

Feature: Added support for displaying and editing metadata of multiple files #12476

merged 9 commits into from
May 30, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
image

@yaira2
Copy link
Member

yaira2 commented May 29, 2023

Does this work for the preview pane or is that out of scope?

@hishitetsu
Copy link
Member Author

Does this work for the preview pane or is that out of scope?

It's out of scope since the preview pane itself doesn't support the display of multiple files.

@hishitetsu hishitetsu requested a review from yaira2 May 30, 2023 00:00
yaira2
yaira2 previously approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 30, 2023
@yaira2 yaira2 merged commit 4785b53 into files-community:main May 30, 2023
hishitetsu added a commit to hishitetsu/Files that referenced this pull request May 30, 2023
@hishitetsu
Revert "Feature: Added support for displaying and editing metadata of…
7a9f1ac 
… multiple files (files-community#12476)"

This reverts commit 4785b53.
@hishitetsu hishitetsu deleted the EditMultipleMetadata branch May 30, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support for editing metadata of multiple files simultaneously
2 participants
@hishitetsu @yaira2