Fix: Fixed SourceGenerator build failure #12471

Poker-sang · 2023-05-28T10:41:35Z

Resolved / Related Issues

Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related: Code Quality: Use SourceGenerator to simplify DependencyProperty #11587 (comment)

Validation
How did you test these changes?

Did you build the app and test your changes?
Did you check for accessibility? You can use Accessibility Insights for this.
Did you remove any strings from the en-us resource file?
- Did you search the solution to see if the string is still being used?
Did you implement any design changes to an existing feature?
- Was this change approved?
Are there any other steps that were used to validate these changes?
1. Open app ...
2. Click settings button ...

Screenshots

0x5bfa · 2023-05-28T11:24:49Z

We do not use Any CPU.

Have to specify respective configurations in following file(Any CPU to x86, x64, arm64):

Files/Files.sln

Lines 377 to 406 in 9fab836

    
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|arm64.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|arm64.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x64.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x64.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x86.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x86.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x86.Build.0 = Debug|Any CPU

Have to make have exactly the same property as right one.

<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<IsTrimmable>true</IsTrimmable>
<Configurations>Debug;Release;Stable;Preview;Store</Configurations>
<Platforms>x86;x64;arm64</Platforms>
<RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

Files.App.Storage

Files/src/Files.App.Storage/Files.App.Storage.csproj

Lines 3 to 9 in 9fab836

    
           <TargetFramework>net7.0-windows10.0.22621.0</TargetFramework> 
        
           <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion> 
        
           <Nullable>enable</Nullable> 
        
           <IsTrimmable>true</IsTrimmable> 
        
           <Configurations>Debug;Release;Stable;Preview;Store</Configurations> 
        
           <Platforms>x86;x64;arm64</Platforms> 
        
           <RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

SourceGenerator

Files/src/Files.SourceGenerator/Files.SourceGenerator.csproj

Lines 4 to 8 in 9fab836

    
           <TargetFramework>netstandard2.0</TargetFramework> 
        
           <LangVersion>preview</LangVersion> 
        
           <Nullable>enable</Nullable> 
        
           <IncludeBuildOutput>false</IncludeBuildOutput> 
        
           <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>

May have to remove properties(OutputItemType="Analyzer" ReferenceOutputAssembly="false" )

Files/src/Files.App/Files.App.csproj

Lines 116 to 119 in 9fab836

    
               <ProjectReference Include="..\Files.Sdk.Storage\Files.Sdk.Storage.csproj" /> 
        
               <ProjectReference Include="..\Files.Shared\Files.Shared.csproj" /> 
        
               <ProjectReference Include="..\Files.SourceGenerator\Files.SourceGenerator.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" /> 
        
           </ItemGroup>

Poker-sang · 2023-05-28T13:29:44Z

@0x5bfa I am sorry. I understand what you mean, but these options must be specified. It is necessary for a Source Generator(analyzer) project. According to MSDN.

OutputItemType="Analyzer" ReferenceOutputAssembly="false"

<IncludeBuildOutput>false</IncludeBuildOutput> 
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>

And IsTrimable option is available only in .NET6 or greater can be used(MSDN). This project is using .netstandard2.0. In fact, the code of this project is not compiled into the application (because it is an analyzer), so it does not matter if it is trimmed or not

As for the AnyCPU config. I don't mean to use it. But if I use x86, x64 or arm64, it will build failed with CSC: warning CS8034.

0x5bfa · 2023-05-28T13:36:50Z

Thank you for telling those.

In any way, can you remove changes from PathBreadcrumb.xaml.cs for a while? Unfortunately, adding Any CPU is not fundamental issue resolving.

Files/src/Files.App/UserControls/PathBreadcrumb.xaml.cs

Lines 13 to 20 in 9fab836

    
           [DependencyProperty<ToolbarViewModel>("ViewModel")] 
        
           public sealed partial class PathBreadcrumb : UserControl 
        
           { 
        
           	public PathBreadcrumb() 
        
           	{ 
        
           		InitializeComponent(); 
        
           	}

Poker-sang · 2023-05-28T13:40:43Z

Thank you for telling those.

In any way, can you remove changes from PathBreadCrumb.xaml.cs? That is the issue now.

I can do it. But I'm concerned that someone has already developed based on the modified PathBreadCrumb.xaml.cs, which could lead to conflicts if I remove it.

0x5bfa · 2023-05-28T13:44:16Z

No worries. The reason why I decided to use this file for a test is this file has much less commit history, as you can see it, there is no functional update in the past months.

You can

remove [DependencyProperty<ToolbarViewModel>("ViewModel")]

add

public ToolbarViewModel ViewModel
{
	get => (ToolbarViewModel)GetValue(ViewModelProperty);
	set => SetValue(ViewModelProperty, value);
}

public static readonly DependencyProperty ViewModelProperty =
	DependencyProperty.Register(nameof(ViewModel), typeof(ToolbarViewModel), typeof(PathBreadcrumb), new PropertyMetadata(null));

Poker-sang · 2023-05-28T13:51:33Z

Unfortunately, adding Any CPU is not fundamental issue resolving.

hmm, actually we have already add AnyCPU config, this PR does not add a new config. And ms recommends to use AnyCPU in an analyzer project.

No worries

Ok I will remove it.

Files/Files.sln

Lines 377 to 406 in 40a0f0f

    
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Debug|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Preview|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|arm64.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|arm64.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x64.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x64.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x86.ActiveCfg = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Release|x86.Build.0 = Release|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Stable|x86.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|arm64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|arm64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x64.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x64.Build.0 = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x86.ActiveCfg = Debug|Any CPU 
        
           {6FA07816-DE0A-4D49-84E8-38E953A33C87}.Store|x86.Build.0 = Debug|Any CPU

0x5bfa · 2023-05-28T13:54:06Z

Oh really? Then keep it please sorry.

And ms recommends to use AnyCPU in an analyzer project.

Can you link?

Poker-sang · 2023-05-28T14:07:40Z

Can you link?

Sorry, I am not sure if it is mentioned in MSDN. But if you look at any repos, they all use AnyCPU. Such as Roslyn or CommunityToolkit.

0x5bfa · 2023-05-28T14:08:29Z

@Poker-sang I am totally sorry for the inconvenience! Can you keep it(Revert the latest commit)?

0x5bfa · 2023-05-28T14:09:39Z

@yaira2 '@Poker-sang' found the way to make the compiler successful instead of discarding all changes.

Poker-sang · 2023-05-28T14:10:00Z

No problem

Poker-sang · 2023-05-28T14:14:51Z

I only tested GitHub Action and it was successful, I don't know if Azure Pipeline will be fine, hopefully no issues.

0x5bfa

LGTM. Thank you!🎉

yaira2 · 2023-05-28T14:16:07Z

@Poker-sang thank you for the quick fix!

0x5bfa · 2023-05-28T14:30:52Z

@yaira2

Poker-sang · 2023-05-30T06:14:50Z

Oh really? Then keep it please sorry.

Can you link?

I think I know why it is configured with AnyCPU. As I said it is an analyzer project and will not be compiled into the application. The DLL it generates will only be loaded by the VS or dotnet compiler. So the target platform of the DLL depends on the CPU architecture of the computer where the code is compiled and not on the user's computer. For example, my computer should be configured with x64, while Azure server might use Arm64. For convenience and without specifying a particular configuration, AnyCPU is the best. ☺️

That's why x86 and Arm64 were wrong before. Because they used x86 or Arm64 configurations, while Azure and Github servers are x64

0x5bfa · 2023-05-30T07:24:17Z

Oh thank you for the long response, and I finally fully understand the reason why. I will add that comment to the project file to mention that.

0x5bfa · 2023-07-07T13:21:42Z

@Poker-sang Do you think we can change the attribution to following way?

[DependencyProperty]
public ToolbarViewModel ViewModel { get; set; }

Inspiration:

Poker-sang · 2023-07-07T13:56:51Z

Do you think we can change the attribution to following way?

Sure. It seems a way to have better readability. And we can even put comments on it.

0x5bfa · 2023-07-07T14:06:50Z

It's nice to hear. Would you like to work on?

Poker-sang · 2023-07-07T14:12:22Z

Maybe we can open an issue first. And I will work on it in a few days. Are you in a hurry to need this?

0x5bfa · 2023-07-07T14:22:25Z

Not at all, take your time please. Issued #12889.

Poker-sang added 7 commits May 28, 2023 15:10

Create build

088050d

Rename build to build.yml

b38159a

Update build.yml

20ce901

Update build.yml x86

403bcde

Update Files.SourceGenerator.csproj

fd33ddd

Restore build.yml

8344b2f

Delete build.yml

40a0f0f

0x5bfa self-requested a review May 28, 2023 14:09

yaira2 changed the title ~~Fix: SourceGenerator build failure~~ Fix: Fixed SourceGenerator build failure May 28, 2023

yaira2 added the needs - code review label May 28, 2023

0x5bfa approved these changes May 28, 2023

View reviewed changes

yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 28, 2023

yaira2 merged commit e8ab068 into files-community:main May 28, 2023

0x5bfa mentioned this pull request Jul 7, 2023

Code Quality: Moved App.Commands & App.Contexts to App.Data #12887

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Fixed SourceGenerator build failure #12471

Fix: Fixed SourceGenerator build failure #12471

Poker-sang commented May 28, 2023

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023

0x5bfa commented May 28, 2023

Poker-sang commented May 28, 2023

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa left a comment

yaira2 commented May 28, 2023

0x5bfa commented May 28, 2023

Poker-sang commented May 30, 2023 •

edited

Loading

0x5bfa commented May 30, 2023

0x5bfa commented Jul 7, 2023 •

edited

Loading

Poker-sang commented Jul 7, 2023 •

edited

Loading

0x5bfa commented Jul 7, 2023

Poker-sang commented Jul 7, 2023

0x5bfa commented Jul 7, 2023

Fix: Fixed SourceGenerator build failure #12471

Fix: Fixed SourceGenerator build failure #12471

Conversation

Poker-sang commented May 28, 2023

0x5bfa commented May 28, 2023 • edited Loading

Poker-sang commented May 28, 2023 • edited Loading

0x5bfa commented May 28, 2023 • edited Loading

Poker-sang commented May 28, 2023

0x5bfa commented May 28, 2023 • edited Loading

Poker-sang commented May 28, 2023 • edited Loading

0x5bfa commented May 28, 2023 • edited Loading

Poker-sang commented May 28, 2023 • edited Loading

0x5bfa commented May 28, 2023

0x5bfa commented May 28, 2023

Poker-sang commented May 28, 2023

Poker-sang commented May 28, 2023 • edited Loading

0x5bfa left a comment

Choose a reason for hiding this comment

yaira2 commented May 28, 2023

0x5bfa commented May 28, 2023

Poker-sang commented May 30, 2023 • edited Loading

0x5bfa commented May 30, 2023

0x5bfa commented Jul 7, 2023 • edited Loading

Poker-sang commented Jul 7, 2023 • edited Loading

0x5bfa commented Jul 7, 2023

Poker-sang commented Jul 7, 2023

0x5bfa commented Jul 7, 2023

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

0x5bfa commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

Poker-sang commented May 28, 2023 •

edited

Loading

Poker-sang commented May 30, 2023 •

edited

Loading

0x5bfa commented Jul 7, 2023 •

edited

Loading

Poker-sang commented Jul 7, 2023 •

edited

Loading