Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where the format option was incorrectly shown #12444

Conversation

tsurrdurr
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: "Format..." shouldn't be visible if items are selected #12401

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Navigate to a non-system hard drive's root folder.
    2. Right click on any file or folder. Without the fix, it would contain a "Format..." option.
    3. Right click on an empty space. The option "Format..." should be still available there.

@yaira2 yaira2 changed the title Fix: Fixed an issue that when files/folders are selected, their context menu would offer a "format drive" option (#12401) Fix: Fixed an issue where the format option was incorrectly shown May 24, 2023
@yaira2
Copy link
Member

yaira2 commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Jul 25, 2023

@tsurrdurr apologies for the delay on reviewing this, can you resolve the merge conflicts?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 6, 2023
@yaira2 yaira2 merged commit 4ecb950 into files-community:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Format..." shouldn't be visible if items are selected
2 participants