Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Changed the format of the banner at extracting archives #12412

Merged
merged 1 commit into from
May 21, 2023

Conversation

hishitetsu
Copy link
Member

This formats the banner at extracting in the same format as the banner at compressing.
#12362 occurs when the title and message are short enough to be displayed on one line.
This does not completely fix #12362 but reduce its occurrence.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
Before:
スクリーンショット 2023-05-21 110825

After:
スクリーンショット 2023-05-21 110515

Banner at compression (for comparison):
スクリーンショット 2023-05-21 110621

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 21, 2023
@yaira2 yaira2 merged commit 0838789 into files-community:main May 21, 2023
@hishitetsu hishitetsu deleted the FixExtractingInfo branch May 21, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Progress bar is overlapping text in ongoing operations
2 participants