Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Renamed Copy location to Copy path #12392

Merged
merged 2 commits into from
May 19, 2023
Merged

Feature: Renamed Copy location to Copy path #12392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aab3aeb
Copy as path
hishitetsu May 19, 2023
15742f9
Copy path
hishitetsu May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions specs/RichCommand/CommandList.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ This is the list of all commands defined in `CommandCodes` enum except `None`.
| | ExitCompactOverlay | Exit compact overlay | Exit compact overlay | Ctrl+Alt+Down |
| | ToggleCompactOverlay | Toggle compact overlay | Toggle compact overlay | F12 |
| | Search | Search | Go to search box | Ctrl+F, F3 |
| | SearchUnindexedItems | Search unindexed items | Search for unindexed items | |
| | Redo | Redo | Redo the last file operation | Ctrl+Y |
| | Undo | Undo | Undo the last file operation | Ctrl+Z |
| | EditPath | Edit path | Focus path bar | Ctrl+L, Alt+D |
Expand All @@ -18,13 +19,14 @@ This is the list of all commands defined in `CommandCodes` enum except `None`.
| | TogglePreviewPane | Toggle the preview pane | Toggle whether to show preview pane | Ctrl+P |
| | ToggleSidebar | Toggle the sidebar | Toggle whether to show sidebar | Ctrl+B |
| File System | CopyItem | Copy | Copy item(s) to clipboard | Ctrl+C |
| | CopyPath | Copy location | Copy path of item to clipboard | Ctrl+Shift+C |
| | CopyPath | Copy as path | Copy path of item to clipboard | Ctrl+Shift+C |
| | CutItem | Cut | Cut item(s) to clipboard | Ctrl+X |
| | PasteItem | Paste | Paste item(s) from clipboard to current folder | Ctrl+V |
| | PasteItemToSelection | Paste | Paste item(s) from clipboard to selected folder | Ctrl+Shift+V |
| | DeleteItem | Delete | Delete item(s) | Delete, Ctrl+D |
| | DeletemeItemPermanently | Delete permanently | Delete item(s) permanently | Shift+Delete |
| | CreateFolder | Folder | Create new folder | |
| | CreateFolderWithSelection | Create folder with selection | Create a folder with the currently selected item(s) | |
| | AddItem | New | Create new item | Ctrl+Shift+N |
| | CreateShortcut | Create shortcut | Create new shortcut(s) to selected item(s) | |
| | CreateShortcutFromDialog | Shortcut | Create new shortcut to any item | |
Expand Down Expand Up @@ -65,7 +67,8 @@ This is the list of all commands defined in `CommandCodes` enum except `None`.
| | DecompressArchiveToChildFolder | Extract to _NewFolderName_ | Extract items from selected archive(s) to new folder | |
| Image Manipulation | RotateLeft | Rotate left | Rotate selected image(s) to the left | |
| | RotateRight | Rotate right | Rotate selected image(s) to the right | |
| Open | OpenSettings | Settings | Open settings page | Ctrl+, |
| Open | OpenProperties | Open properties | Open properties window | Alt+Enter |
| | OpenSettings | Settings | Open settings page | Ctrl+, |
| | OpenTerminal | Open in terminal | Open folder in terminal | Ctrl+\` |
| | OpenTerminalAsAdmin | Open in terminal as administrator | Open folder in terminal as administrator | Ctrl+Shift+\` |
| Layout | LayoutDecreaseSize | Decrease size | Decrease icon size in grid view | Ctrl+- |
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/CopyPathAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ internal class CopyPathAction : IAction
{
private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();

public string Label { get; } = "CopyLocation".GetLocalizedResource();
public string Label { get; } = "CopyAsPath".GetLocalizedResource();

public string Description => "CopyPathDescription".GetLocalizedResource();

public RichGlyph Glyph { get; } = new RichGlyph(opacityStyle: "ColorIconCopyLocation");
public RichGlyph Glyph { get; } = new RichGlyph(opacityStyle: "ColorIconCopyPath");

public HotKey HotKey { get; } = new(Keys.C, KeyModifiers.CtrlShift);

Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/ResourceDictionaries/PathIcons.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@
</Setter>
</Style>

<Style x:Key="ColorIconCopyLocation" TargetType="local:OpacityIcon">
<Style x:Key="ColorIconCopyPath" TargetType="local:OpacityIcon">
<Setter Property="Template">
<Setter.Value>
<ControlTemplate>
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@
<data name="NavigationToolbarNewWindow.Label" xml:space="preserve">
<value>New window</value>
</data>
<data name="CopyLocation" xml:space="preserve">
<value>Copy location</value>
<data name="CopyAsPath" xml:space="preserve">
hishitetsu marked this conversation as resolved.
Show resolved Hide resolved
<value>Copy as path</value>
yaira2 marked this conversation as resolved.
Show resolved Hide resolved
</data>
<data name="Browse" xml:space="preserve">
<value>Browse</value>
Expand Down