Feature: Git Integration Phase 3

[ferrariofilippo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Feature: Git integration #11014

IMPORTANT
Please, if you try checking out remotes, place a breakpoint at line 149 of GitHelpers.cs and make sure that the method is executed only once
There was a bug where it would keep on creating new branches because of selection changing. It should be fixed now, but it's better to be careful

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app and navigate to a git directory
  2. Click on the branch name
  3. Click on New Branch

Screenshots (optional)

[hecksmosis]

I am getting a bug where when you open the branches menu it glitches. (POV: You don't pay for bandicam)

bandicam.2023-05-19.19-38-21-532.mp4

[ferrariofilippo]

I am getting a bug where when you open the branches menu it glitches.

Does it eventually stop flickering? That might be related to the changes being applied, and so the directory info being updated. We might fix that using some kind of BulkOperation that we use for other operations

[hecksmosis]

I am getting a bug where when you open the branches menu it glitches.

Does it eventually stop flickering? That might be related to the changes being applied, and so the directory info being updated. We might fix that using some kind of BulkOperation that we use for other operations

Yes, it stops after a bit. Also, this is not as much of a problem in directories with fewer branches

[ferrariofilippo]

@hecksmosis can you please test if the last commit fixes the issue?

[hecksmosis]

@hecksmosis can you please test if the last commit fixes the issue?

I still get the flickering on the latest commit (there are about 40 branches to be shown)

[ferrariofilippo]

I can't reproduce the bug, but I know where it may come from, so I'm going trial and error

[hecksmosis]

I can't reproduce the bug, but I know where it may come from, so I'm going trial and error

Ok, ping me and I'll test

[ferrariofilippo]

Can you test now, I pushed a commit that should fix it

[hecksmosis]

Yes, it's fixed (btw, it was more like 110 branches so should be robust enough)

[yaira2]

LGTM

[0x5bfa]

Great work!🎉 Thank you @ferrariofilippo!