Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the create button was always disabled in new shortcut dialog #12230

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Disable warning when a new name is empty #12150

The former code was blocking all the listeners subscribed to the change of IsLocationValid

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Right click on empty space
    3. Click new > new shortcut
    4. Enter an invalid path and then a valid one

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 30, 2023
@yaira2 yaira2 merged commit 638e3b7 into files-community:main Apr 30, 2023
@yaira2 yaira2 changed the title Fix: create button is always disabled in new shortcut dialog Fix: Create button is always disabled in new shortcut dialog Apr 30, 2023
@yaira2 yaira2 changed the title Fix: Create button is always disabled in new shortcut dialog Fix: Fixed issue where the create button was always disabled in new shortcut dialog Apr 30, 2023
@ferrariofilippo ferrariofilippo deleted the Cannot_Create_Shortcuts branch April 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants