Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where the tab sometimes had the wrong icon #12190

Merged
merged 9 commits into from
Jun 4, 2023
Merged

Fix: Fixed issue where the tab sometimes had the wrong icon #12190

merged 9 commits into from
Jun 4, 2023

Conversation

marcofranzen99
Copy link
Contributor

@marcofranzen99 marcofranzen99 commented Apr 24, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Incorrect tab icon for Cloud Drives & WSL Distributions #11795

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Icon of the cloud provider is shown in the root of the cloud drive
    2. Icon of the cloud provider is not shown in subdirectories of the cloud drive
    3. Icon of the WSL distribution is shown in the root of the WSL distribution
    4. Icon of the WSL distribution is not shown in subdirectories of the WSL distribution

Screenshots (optional)
Add screenshots here.

@marcofranzen99
Merge remote-tracking branch 'upstream/main' into 11795_incorrect_tab…
82ce238 
…_icon

# Conflicts:
#	src/Files.App/Filesystem/Cloud/CloudDrivesManager.cs
@marcofranzen99
include namespace
865f79a
@marcofranzen99
Merge remote-tracking branch 'upstream/main' into 11795_incorrect_tab…
59c113b 
…_icon

# Conflicts:
#	src/Files.App/Filesystem/Cloud/CloudDrivesManager.cs
#	src/Files.App/Filesystem/WSLDistroManager.cs
@yaira2 yaira2 changed the title Fix: Show correct tab icon for wsl and cloud drives Fix: Fixed issue where the tab sometimes had the wrong icon May 4, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 4, 2023
@yaira2 yaira2 merged commit a1802c0 into files-community:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect tab icon for Cloud Drives & WSL Distributions
2 participants
@marcofranzen99 @yaira2