Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added IconAltAccentBrush for toolbar icons #12118

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 19, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Switch to dark mode
    3. Verify that the new, paste and rename icons have a semitransparent fill
    4. Switch to light mode and verify they have a solid white fill

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Feature: Reduce opacity of the icon fill in dark mode Feature: Added IconAltAccentBrush for toolbar icons Apr 19, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 19, 2023
@yaira2 yaira2 merged commit 74f3262 into main Apr 19, 2023
@yaira2 yaira2 deleted the ya/IconContrast branch April 19, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Reduce opacity of the black background of the toolbar icons
1 participant