Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: A workaround to avoid AccessViolationException #12089

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: System.AccessViolationException in ContextMenu #12078

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Update ContextMenu.cs Fix: A workaround to avoid AccessViolationException Apr 17, 2023
@hishitetsu hishitetsu marked this pull request as draft April 17, 2023 00:06
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me! Seems to have fixed the issue.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 17, 2023
@hishitetsu hishitetsu marked this pull request as ready for review April 17, 2023 02:46
@hishitetsu
Copy link
Member Author

Thank you!

@yaira2 yaira2 merged commit ebb1e18 into files-community:main Apr 17, 2023
@hishitetsu hishitetsu deleted the WorkaroundForContextMenu branch April 17, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: System.AccessViolationException in ContextMenu
2 participants