Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display "shield overlay" indicating when elevation is required #12068

Merged
merged 10 commits into from
Apr 16, 2023

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Display "shield overall" indicating elevation is required #4845

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    • Tested for shortcuts as well.

Screenshots
ShieldDisplay

@yaira2 yaira2 changed the title Feature: Display "shield overall" indicating elevation is required Feature: Display "shield overlay" indicating elevation is required Apr 14, 2023
@yaira2 yaira2 changed the title Feature: Display "shield overlay" indicating elevation is required Feature: Display "shield overlay" indicating when elevation is required Apr 14, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 14, 2023

This reminds me that we really need a reusable control for displaying thumbnails with all the overlays 😂

@QuaintMako
Copy link
Contributor Author

This reminds me that we really need a reusable control for displaying thumbnails with all the overlays 😂

I've made an issue to track it (#12071), do not hesitate to complete it for I am not sure of everything it entails.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 16, 2023
@yaira2 yaira2 merged commit 770691a into files-community:main Apr 16, 2023
@QuaintMako QuaintMako deleted the ShieldIcon branch April 23, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Display "shield overall" indicating elevation is required
2 participants