Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where the adaptive layout toggle was always disabled #12049

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix: Fixed issue where the adaptive layout toggle was always disabled #12049

merged 1 commit into from
Apr 14, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Apr 11, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Unable to select adaptive layout mode #12048

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open the layout flyout in the toolbar and observe the state of the Adaptive toggle

@gave92 gave92 closed this Apr 11, 2023
@gave92 gave92 reopened this Apr 11, 2023
@yaira2 yaira2 changed the title Fix: Fix adaptive layout toggle always disabled Fix: Fixed issue where the adaptive layout toggle was always disabled Apr 11, 2023
ferrariofilippo
ferrariofilippo approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 14, 2023
@yaira2 yaira2 merged commit e61ffa2 into files-community:main Apr 14, 2023
@gave92 gave92 deleted the adaptive branch April 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unable to select adaptive layout mode
3 participants
@gave92 @ferrariofilippo @yaira2