Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added swipe gesture for back/forward navigation #12043

Merged
merged 48 commits into from
Apr 23, 2023

Conversation

heftymouse
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

    Closes Feature: Implement back/forward touch gestures #100

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

If you have the time you're encourage to clone this PR and see if the gestures 'feel right' to you. Please leave a comment if there's anything that could be improved.

@heftymouse
Copy link
Contributor Author

Please ignore the fact that there's 23 extra commits I accidentally pressed the wrong button

@yaira2 yaira2 changed the title Feature: Add swipe gesture for back/forward navigation Feature: Added swipe gesture for back/forward navigation Apr 11, 2023
@d2dyno1 d2dyno1 removed their request for review April 17, 2023 08:54
@hishitetsu
Copy link
Member

I tried. It is very cool and works well for me!
It would be better if it could refresh the page when swiping down.

One could find themselves accidentally triggering it if they use a lot of
force when scrolling which could get annoying

I have never had an unintended swipe, but I think there should be an option.

@yaira2
Copy link
Member

yaira2 commented Apr 18, 2023

It would be better if it could refresh the page when swiping down.

We used to have this but it wasn't widely used and was unreliable, users navigate back and forth a lot more than they refresh.

@hishitetsu
Copy link
Member

We used to have this but it wasn't widely used and was unreliable

I didn't know it existed before. With this implementation, it appears to be reliable.

@yaira2
Copy link
Member

yaira2 commented Apr 18, 2023

It wouldn't hurt to give it another try 👍

@yaira2
Copy link
Member

yaira2 commented Apr 18, 2023

One could find themselves accidentally triggering it if they use a lot of
force when scrolling which could get annoying

@heftymouse I'm going to do some testing to see how often this happens.

@yaira2
Copy link
Member

yaira2 commented Apr 18, 2023

I agree that it's too sensitive, we can solve this by only triggering the action if the layout is already scrolled to the left or right.

@yaira2
Copy link
Member

yaira2 commented Apr 20, 2023

I think this need to be disabled on the column layout.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 23, 2023
@yaira2 yaira2 merged commit fdfe21d into files-community:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Implement back/forward touch gestures
5 participants