-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added swipe gesture for back/forward navigation #12043
Conversation
Please ignore the fact that there's 23 extra commits I accidentally pressed the wrong button |
I tried. It is very cool and works well for me!
I have never had an unintended swipe, but I think there should be an option. |
We used to have this but it wasn't widely used and was unreliable, users navigate back and forth a lot more than they refresh. |
I didn't know it existed before. With this implementation, it appears to be reliable. |
It wouldn't hurt to give it another try 👍 |
@heftymouse I'm going to do some testing to see how often this happens. |
I agree that it's too sensitive, we can solve this by only triggering the action if the layout is already scrolled to the left or right. |
I think this need to be disabled on the column layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes Feature: Implement back/forward touch gestures #100
Validation
How did you test these changes?
If you have the time you're encourage to clone this PR and see if the gestures 'feel right' to you. Please leave a comment if there's anything that could be improved.