New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed incorrect aperture values #12038

Merged

yaira2 merged 1 commit into files-community:service/2.4.61 from hishitetsu:FixAperture

Apr 14, 2023

Member

hishitetsu commented Apr 10, 2023

Targeted to the servicing branch

Resolved / Related Issues

Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes Bug: Incorrect Aperture values are shown for photos #11516

Validation
How did you test these changes?

Did you build the app and test your changes?
Did you check for accessibility? You can use Accessibility Insights for this.
Did you remove any strings from the en-us resource file?
- Did you search the solution to see if the string is still being used?
Did you implement any design changes to an existing feature?
- Was this change approved?
Are there any other steps that were used to validate these changes?


          Fix aperture property

6a580db

yaira2 added the needs - code review label

ferrariofilippo approved these changes

View reviewed changes

Contributor

ferrariofilippo left a comment

LGTM and works for me (I tested 40 photos with different apertures)

yaira2 added ready to merge and removed needs - code review labels

yaira2 merged commit 9fcd9f0 into files-community:service/2.4.61

hishitetsu deleted the FixAperture branch

April 14, 2023 04:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels