Feature: Auto restore tabs if the app crashes

[hishitetsu]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Auto restore tabs if the app crashes #5993

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?

[QuaintMako]

With the current implementation, does the user's original setting is preserved after the restart?

[hishitetsu]

It should because the current implementation is the same mechanism as when changing languages.
I'm currently working on further improvements to automatically restart the app without clicking notifications.

[hishitetsu]

Automatic restart is now implemented.
When Launcher.LaunchUriAsync() is called, the method somehow doesn't return even though a new app is launched, so I use a timer to force it to end.

Notifications now doesn't launch the application when clicked in favor of automatic restart.

[ferrariofilippo]

When Launcher.LaunchUriAsync() is called, the method somehow doesn't return even though a new app is launched

It might be related with #3652

[hishitetsu]

As it is, if I get an error when I view a particular page, I get endless restarts.

It needs a little more improvement.

[hishitetsu]

When Launcher.LaunchUriAsync() is called, the method somehow doesn't return even though a new app is launched

It might be related with #3652

But it returns normally when changing language.
Maybe the UI thread is going haywire because it is after the exception occurred.

Files/src/Files.App/UserControls/RestartControl.xaml.cs

Lines 51 to 57 in 29c35b0

	private async void YesButton_Click(object sender, RoutedEventArgs e)
	{
	UserSettingsService.AppSettingsService.RestoreTabsOnStartup = true; // Tells the app to restore tabs when it's next launched
	App.SaveSessionTabs(); // Saves the open tabs
	await Launcher.LaunchUriAsync(new Uri("files-uwp:")); // Launches a new instance of Files
	Process.GetCurrentProcess().Kill(); // Closes the current instance
	}

[ferrariofilippo]

Maybe the UI thread is going haywire because it is after the exception occurred.

Yes that might be the case

[hishitetsu]

As it is, if I get an error when I view a particular page, I get endless restarts.

I addressed it. Now ready for review.

[QuaintMako]

@hishitetsu may I ask you what was the process you used to provoke the crash of the app to test it myself?

[hishitetsu]

@hishitetsu may I ask you what was the process you used to provoke the crash of the app to test it myself?

I tested that by embedding the code that throws the Exception for debugging purposes.

[QuaintMako]

It works as expected for me.

[yaira2]

LGTM