Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Invalid Archive Name & Invalid Shortcut Location Warning #11997

Merged

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 6, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add invalid name and path warnings to modals #12044

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and try to create an archive
    2. Clear archive name

Screenshots (optional)
4
3
5

@ferrariofilippo ferrariofilippo changed the title Feature: Add Invalid Archive Name Warning Feature: Add Invalid Archive Name & Invalid Shortcut Location Warning Apr 6, 2023
@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Apr 6, 2023

I'll implement a custom control to reduce code duplication Done

@yaira2
Copy link
Member

yaira2 commented Apr 10, 2023

Can you link an issue for this?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Apr 14, 2023

I'm having some troubles with rename dialog because of an exception, I'll try to find a workaround

Edit. I found one but that needs some hard testing because it may cause issues

@ferrariofilippo ferrariofilippo marked this pull request as draft April 14, 2023 20:02
@ferrariofilippo ferrariofilippo marked this pull request as ready for review April 14, 2023 20:57
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 16, 2023
@yaira2 yaira2 merged commit f978298 into files-community:main Apr 16, 2023
@ferrariofilippo ferrariofilippo deleted the Feature_Invalid_Archive_Name branch April 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add invalid name and path warnings to modals
2 participants