Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where column view jumps from left to right #11986

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a folder using columns layout
    2. Navigate using arrow keys

@yaira2 yaira2 changed the title Fixed: Column view scroll jumps from left to right Fix: Fixed issue where column view jumps from left to right Apr 5, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 16, 2023

Do the right and left arrow keys still scroll?

@ferrariofilippo
Copy link
Contributor Author

Do the right and left arrow keys still scroll?

Horizontally yes

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 17, 2023
@yaira2 yaira2 merged commit 09d65c0 into files-community:main Apr 17, 2023
@ferrariofilippo ferrariofilippo deleted the Fixed_Columns_View_Moving branch April 17, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Column view scroll jumps from left to right when using arrow keys for navigation
2 participants