Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added properties option when right clicking recent files #11985

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add properties option when right clicking recent files #11434

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@QuaintMako
Copy link
Contributor

QuaintMako commented Apr 12, 2023

I am managing to get a crash when playing around with the code, that is not happening all the time though:

1- Open the property window of a recent file and open the detail panel.
2- Open a second property window of the same file, open the detail panel.
3- Try to close the first window. It may lead to a crash.

I'll try get the log files later today, and try to see if I can reproduce it when opening properties a file that is not in the recent files list;

@QuaintMako
Copy link
Contributor

Aside of that random crash, the code looks clean to me and does what was asked for!

@hishitetsu
Copy link
Member Author

I'll try get the log files later today, and try to see if I can reproduce it when opening properties a file that is not in the recent files list;

I can reproduce it and it also occurs when opening properties outside of the recent files list.
I think this is a serious issue, but it is a separate issue from this PR.

@QuaintMako
Copy link
Contributor

I'll try get the log files later today, and try to see if I can reproduce it when opening properties a file that is not in the recent files list;

I can reproduce it and it also occurs when opening properties outside of the recent files list. I think this is a serious issue, but it is a separate issue from this PR.

Did you already open an issue for it?

@hishitetsu
Copy link
Member Author

hishitetsu commented Apr 12, 2023

@QuaintMako no, can you please open an issue?
I opened the issue (#12057). However, I'm not even sure if this is related to the property window. If you have any additional information, please comment it.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 14, 2023
@yaira2 yaira2 merged commit 323545a into files-community:main Apr 14, 2023
@hishitetsu hishitetsu deleted the OpenRecentFileProperties branch April 14, 2023 02:02
@@ -121,6 +121,7 @@ public void ReloadWidgets()
{
Widgets.ViewModel.InsertWidget(new(recentFilesWidget, (value) => UserSettingsService.PreferencesSettingsService.RecentFilesWidgetExpanded = value, () => UserSettingsService.PreferencesSettingsService.RecentFilesWidgetExpanded), 4);

recentFilesWidget.AppInstance = AppInstance;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the cause of #12160 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested just after this PR was merged and the CPU usage is not high.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add properties option when right clicking recent files
3 participants