-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added properties option when right clicking recent files #11985
Feature: Added properties option when right clicking recent files #11985
Conversation
I am managing to get a crash when playing around with the code, that is not happening all the time though: 1- Open the property window of a recent file and open the detail panel. I'll try get the log files later today, and try to see if I can reproduce it when opening properties a file that is not in the recent files list; |
Aside of that random crash, the code looks clean to me and does what was asked for! |
I can reproduce it and it also occurs when opening properties outside of the recent files list. |
Did you already open an issue for it? |
@QuaintMako |
@@ -121,6 +121,7 @@ public void ReloadWidgets() | |||
{ | |||
Widgets.ViewModel.InsertWidget(new(recentFilesWidget, (value) => UserSettingsService.PreferencesSettingsService.RecentFilesWidgetExpanded = value, () => UserSettingsService.PreferencesSettingsService.RecentFilesWidgetExpanded), 4); | |||
|
|||
recentFilesWidget.AppInstance = AppInstance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the cause of #12160 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved / Related Issues
Closes Feature: Add properties option when right clicking recent files #11434
Validation
How did you test these changes?