Fix: Fixed issue where opening and closing modals quickly may lead to a crash #11928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: Opening and closing modals quickly may lead to a crash #11804
Details
UIHelpers
there's a bool that is set to true when the app is ready to show a new dialogBaseUIAction
is used to reduce code duplication (UIHelpers.PropertyChanged
)DialogExtension.cs
since it was used only once and there was a method that did the same thingSetContentDialogRoot()
since they share the same code. (Note this method is invoked byTryShowAsync()
so everything works same as before)Others
DialogResult
? It has the same values as the predefined enumContentDialogResult
Validation
How did you test these changes?
Del
andEsc