Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Close unfocused blades #11898

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes None

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a path such as C:\Windows\System32 in columns layout
    2. Click on Windows (Single click to open option)

@ferrariofilippo
Copy link
Contributor Author

There's a bug with Double Click To Open: if you double click on a folder which is already opened, it will be close and then reopened. This is due to both ItemTapped and DoubleTapped being raised. The only way to fix this (Microsoft Docs) is to introduce another timer like we do for DoubleClickToRename. I'll try to work on that, should I push the fix here or in a different PR?

@yaira2
Copy link
Member

yaira2 commented Mar 29, 2023

I'll try to work on that, should I push the fix here or in a different PR?

A separate PR, thanks!

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 29, 2023
@yaira2 yaira2 merged commit 381e7ff into files-community:main Mar 29, 2023
@ferrariofilippo ferrariofilippo deleted the Close_Unfocused_Blades branch March 29, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants