Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Improved design of the security property pages #11855

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Feature: Improved design of the security property pages #11855

merged 5 commits into from
Mar 28, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 27, 2023 •
edited
Loading

Description

To adapt with new style, update Security and SecurityAdvanced pages. This changes is not one of security advanced page integration plan.

Details of changes

SecurityPage

  • Change full name displaying style from (FontWeight: SemiLight, FG: Primary) to (FontWeight: Normal, FG: Secondary) in an ACL.
  • Larger add/remove ACL buttons (Padding="8,8")
  • MenuFlyoutSeparator to Border and color is set as DividerStrokeColorDefaultBrush
  • Display 'Advanced permissions' on > button
  • Change 'Change owner' Button to HyperlinkButton
  • Align 'Change owner' left side

SecurityAdvancedPage

  • Change full name displaying style from (FontWeight: SemiLight, FG: Primary) to (FontWeight: Normal, FG: Secondary) in an ACL.
  • Larger add/remove ACL buttons (Padding="8,8")
  • MenuFlyoutSeparator to Border and color is set as DividerStrokeColorDefaultBrush
  • Moveable ListViewItem columns implemented with GridSplitter
  • Transparent DropDownButton
  • Change the way of displaying type from Glyph to Text (Allow or Deny)

Self-check list

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

Security page (Old, New)
image

Old SecurityAdvancedPage
image

New SecurityAdvancedPage
image

@yaira2
Copy link
Member

yaira2 commented Mar 28, 2023

Is this ready for review?

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 28, 2023

Yes

@yaira2 yaira2 changed the title Fix: Fix UI in Security pages Feature: Improved design of the security property pages Mar 28, 2023
yaira2
yaira2 previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 marked this pull request as ready for review March 28, 2023 03:02
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 28, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 28, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit 9fc2ccc into files-community:main Mar 28, 2023
@0x5bfa 0x5bfa deleted the 5bfa/tweak-security branch April 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2