Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update to newer icon codes (pt.1/2) #11822

Merged
merged 7 commits into from
Mar 28, 2023
Merged

Feature: Update to newer icon codes (pt.1/2) #11822

merged 7 commits into from
Mar 28, 2023

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Mar 23, 2023

Visually there is no change

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Bug: Missing icons on Windows 10 #10783

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

TO-DO

The following either

  • can't find exact replacement, or
  • double check context

image

@yaira2 yaira2 changed the title Replaced outdated icon with valid codes Feature: Update to newer icon codes Mar 23, 2023
@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Mar 26, 2023

@yaira2 I don't know what's going on here, but there's something seriously going wrong...
Error list

yaira2
yaira2 previously approved these changes Mar 28, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Mar 28, 2023

@Jay-o-Way can you resolve the merge conflicts?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 28, 2023
@yaira2 yaira2 marked this pull request as ready for review March 28, 2023 17:43
@Jay-o-Way
Copy link
Contributor Author

We're not ready yet. I left a few undone, because I would like for you to double check what they should be replaced with.
image

@yaira2
Copy link
Member

yaira2 commented Mar 28, 2023

We're not ready yet. I left a few undone, because I would like for you to double check what they should be replaced with.

We can cover those in another PR, can you send them in text form so I can copy/paste?

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Mar 28, 2023

We can cover those in another PR, can you send them in text form so I can copy/paste?

Not sure how that would be easy, but there's another way:
Search in files, query = xE[0-5] with regular expression on

@yaira2 yaira2 merged commit 67aa1e0 into files-community:main Mar 28, 2023
@Jay-o-Way Jay-o-Way deleted the fix-icon-codes branch March 28, 2023 21:03
@Jay-o-Way Jay-o-Way changed the title Feature: Update to newer icon codes Feature: Update to newer icon codes (pt.1/2) Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants