Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where new tab icon disappears when window is smaller than 640px #11818

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Mar 23, 2023

Resolved / Related Issues

Changes

  • Now New Tab button is always visible
  • Fixes a bug where you couldn't close tabs (using x button) when window was smaller than 640px

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. NOTE To test changes you have to build Files as release or comment out line 128 of DragZoneHelper.cs (XAML toolbar may interfere with taps)
    2. Resize the window so that it it smaller than 640px
    3. Try to create a tab using the + button

@yaira2 yaira2 changed the title Fixed: New tab icon disappears when window is smaller than 640px Fix: Fixed issue where new tab icon disappears when window is smaller than 640px Mar 23, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 23, 2023
@yaira2 yaira2 merged commit fcfa599 into files-community:main Mar 23, 2023
@ferrariofilippo ferrariofilippo deleted the Always_Show_New_Tab branch March 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: New tab icon disappears when window is smaller than 640 pixels
2 participants