Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where progress was not updated when creating an archive #11811

Merged
merged 9 commits into from
Apr 2, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers..

Archive Name

  • Operation banner was not reporting the name of the archive being created. This PR fixes that issue

Archive Progress

  • This PR doesn't completely resolve the issue (I'll try to open a different PR in SevenZip repo to fix that).
  • If there are at least two folders, progress will be shown correctly (4 folders: 0% -> 25% -> 50% -> 75% -> Completed)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • [ x Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select at least two folders
    2. Create an archive
    3. See that progress is now being reported

@yaira2 yaira2 changed the title Fixed: Progress is not updated when creating an archive Fix: Fixed issue where progress was not updated when creating an archive Mar 22, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 494ca6b into files-community:main Apr 2, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 2, 2023
@yaira2 yaira2 changed the title Fix: Fixed issue where progress was not updated when creating an archive Fix: Fixed issue where progress was not updated when creating an archive Apr 2, 2023
@ferrariofilippo ferrariofilippo deleted the Archive_Progress branch April 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants