Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyModifiers read only when necessary. #11805

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

cinqmilleans
Copy link
Contributor

Resolved / Related Issues
Our way of determining KeyModifiers is not always correct. This pr determines KeyModifiers when needed, based on the state of system-provided keys, instead of updating it manually in real time.

I also removed an unused EventArgs.

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    Test the hotkeys

@yaira2 yaira2 merged commit a7cb4bf into files-community:main Mar 22, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 22, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 22, 2023

Does this fix #11800?

@ferrariofilippo
Copy link
Contributor

Does this fix #11800?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants