Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where transfer progress was always shown as 0% #11769

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

Details
The underlying issue was that progress was null, since the parameter was optional. I made it necessary so that we will avoid similar problems in the future

@yaira2
Copy link
Member

yaira2 commented Mar 19, 2023

What if progress isn't available? For example, I'm not sure if Recycle Bin reports progress.

@ferrariofilippo
Copy link
Contributor Author

What if progress isn't available? For example, I'm not sure if Recycle Bin reports progress.

I just checked: recycle bin doesn't report progress. It will be displayed only a banner saying if the operation succeded or not

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fixed: Progress percent always showing 0% Fix: Fixed issue where transfer progress was always shown as 0% Mar 19, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 19, 2023
@yaira2 yaira2 merged commit c9d8471 into files-community:main Mar 19, 2023
@ferrariofilippo ferrariofilippo deleted the Report_Progress branch March 19, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Progress percent always showing 0% while copying files to the my pc's storage
2 participants