Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where it didn't work to create a shortcut unless an item is selected #11768

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Fix: Fixed issue where it didn't work to create a shortcut unless an item is selected #11768

merged 1 commit into from
Mar 19, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Can not create shortcut unless an item is selected #11766

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

@yaira2 yaira2 changed the title Fixed: Can not create shortcut unless an item is selected Fix: Fixed issue where it didn't work to create a shortcut unless an item is selected Mar 19, 2023
yaira2
yaira2 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 19, 2023
@yaira2 yaira2 merged commit ac52d9f into files-community:main Mar 19, 2023
@ferrariofilippo ferrariofilippo deleted the Create_ShortCut_Always_Enabled branch March 19, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Can not create shortcut unless an item is selected
2 participants
@ferrariofilippo @yaira2