-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Option to open all items in a tag #11598
Feature: Option to open all items in a tag #11598
Conversation
@@ -62,6 +58,8 @@ public FileTagsWidgetViewModel ViewModel | |||
|
|||
private ICommand OpenInNewPaneCommand; | |||
|
|||
private ICommand OpenAllItems; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be moved to a rich command directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cinqmilleans can you check if I implemented the RichCommand properly?
|
||
public string Label => "OpenAllItems".GetLocalizedResource(); | ||
|
||
public RichGlyph Glyph { get; } = new("\uE8E5"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which icon is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try 
?
Was this added to the sidebar as well? |
Not yet, I need |
@@ -48,6 +48,8 @@ public interface ICommandManager : IEnumerable<IRichCommand> | |||
|
|||
IRichCommand RotateLeft { get; } | |||
IRichCommand RotateRight { get; } | |||
|
|||
IRichCommand OpenAllTaggedItems { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing looks off
if (sender is not Grid grid || grid.Parent is not Grid parent) | ||
return; | ||
|
||
LoadContextMenuItem(parent, e, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to create the menu in xaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, anyway I'll mark this as Draft and I'll change this once we have a final context, to avoid working twice
@ferrariofilippo what's the status of this PR? |
There are too many conflicts, I'll close this. |
@QuaintMako do you have any thoughts on a tags context? |
@QuaintMako can I start working on this using a |
Sorry for the very late answer, I don't see any issue creating a TagsContext. It might be helpful in the future for other actions surrounding the tags as well. |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details
FileTagsWidget.xaml
are needed to fix a bug where right clicking on the right of an item wouldn't show the context menuValidation
How did you test these changes?