Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option to open all items in a tag #11598

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Mar 7, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Details

  • Changes from line 99 to 121 of FileTagsWidget.xaml are needed to fix a bug where right clicking on the right of an item wouldn't show the context menu
  • I'll check if I can use RichCommand to implement this feature

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
@@ -62,6 +58,8 @@ public FileTagsWidgetViewModel ViewModel

private ICommand OpenInNewPaneCommand;

private ICommand OpenAllItems;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be moved to a rich command directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cinqmilleans can you check if I implemented the RichCommand properly?


public string Label => "OpenAllItems".GetLocalizedResource();

public RichGlyph Glyph { get; } = new("\uE8E5");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which icon is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a temp icon since OpacityIcon is not working
1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try ?

src/Files.App/App.xaml.cs Outdated Show resolved Hide resolved
@yaira2
Copy link
Member

yaira2 commented Mar 12, 2023

Was this added to the sidebar as well?

@ferrariofilippo
Copy link
Contributor Author

Was this added to the sidebar as well?

Not yet, I need SidebarContext for that

@@ -48,6 +48,8 @@ public interface ICommandManager : IEnumerable<IRichCommand>

IRichCommand RotateLeft { get; }
IRichCommand RotateRight { get; }

IRichCommand OpenAllTaggedItems { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing looks off

if (sender is not Grid grid || grid.Parent is not Grid parent)
return;

LoadContextMenuItem(parent, e, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to create the menu in xaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, anyway I'll mark this as Draft and I'll change this once we have a final context, to avoid working twice

@ferrariofilippo ferrariofilippo marked this pull request as draft March 15, 2023 07:41
@yaira2
Copy link
Member

yaira2 commented Jul 4, 2023

@ferrariofilippo what's the status of this PR?

@ferrariofilippo
Copy link
Contributor Author

There are too many conflicts, I'll close this.
Still it was working, if you think that a TagsContext is fine I'll open a new one

@yaira2
Copy link
Member

yaira2 commented Jul 4, 2023

@QuaintMako do you have any thoughts on a tags context?

@ferrariofilippo
Copy link
Contributor Author

@QuaintMako can I start working on this using a TagsContext or do you have any better idea?

@QuaintMako
Copy link
Contributor

@QuaintMako can I start working on this using a TagsContext or do you have any better idea?

Sorry for the very late answer, I don't see any issue creating a TagsContext. It might be helpful in the future for other actions surrounding the tags as well.

@ferrariofilippo ferrariofilippo deleted the Open_All_Items_In_A_Tag branch September 28, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Option to open all items in a tag
3 participants