Fix: Removed GPL code from FilesLauncher

[0x5bfa]

Description

I found the codes licensed under the GPL v3, though this whole project is licensed MIT license.

Motivation and Context

GPL code cannot be existed in Files.

NOTE CONTRIBUTORS: Even if you want to revert changes, you definitely should not. Please find another way.

Tasks

• Remove codes that reference GPL code.
• Remove GPL code.

Validation

• Built and ran the app
• Tested the changes for accessibility

[0x5bfa]

@yaira2 @gave92 How do you think of this?

[hishitetsu]

Isn't there any regression to this change?

[0x5bfa]

Oppps. Sorry for being irresponsible. We have to discuss this part. This was the problem code that reference to the GPL code and I commented out. I pretty sure that they can be removed safely...

src/Files.OpenDialog/FilesLauncher/OpenInFolder.cpp

HRESULT OpenInFolder::NotifyShellOfNavigation(PCIDLIST_ABSOLUTE pidl)
{

...

	RETURN_IF_FAILED(m_shellWindows->RegisterPending(GetCurrentThreadId(), &pidlVariant, &empty,
		SWC_BROWSER, &m_shellWindowCookie));

	auto document = winrt::make_self<DocumentServiceProvider>();
	auto shellView = winrt::make_self<ShellView>(this, pidl);
	document->RegisterService(IID_IFolderView, shellView.get());

	auto browserApp = winrt::make_self<WebBrowserApp>(m_hwnd, document.get());

	long registeredCookie;
#pragma warning(push)
#pragma warning(                                                                                   \
	disable : 4311 4302) // 'reinterpret_cast': pointer truncation from 'HWND' to 'long',
	// 'reinterpret_cast': truncation from 'HWND' to 'long'
	RETURN_IF_FAILED(m_shellWindows->Register(browserApp.get(), reinterpret_cast<long>(m_hwnd),
		SWC_BROWSER, &registeredCookie));
#pragma warning(pop)

...

	return S_OK;
}

[hishitetsu]

I have tested it. It seems to work well except highlighting a file as noted here.
I think this level of regression would be acceptable.

[yaira2]

Can you fix the merge conflict?

[0x5bfa]

Done here. requesting a new review.

[hishitetsu]

@onein528 Could you merge the main branch and build FilesLauncher again? The file FilesLauncher.exe.sha256 should be generated.

[0x5bfa]

I'll be able to work on that the next week

[0x5bfa]

@hishitetsu What did you say before on Discord? I remember a bit you were talking about unneeded codes.

[hishitetsu]

What did you say before on Discord? I remember a bit you were talking about unneeded codes.

About this.

[0x5bfa]

How can I fix this conflict

Btw, Ready for review.

[hishitetsu]

How can I fix this conflict

FilesystemOperationDialog.xaml is modified in #11557, so you can import the one in the main branch.

[hishitetsu]

If you say about FilesLauncher.exe, you can import the one in your branch, merge the upstream, then build FilesLauncher again.

[0x5bfa]

@hishitetsu Thank you:)

FYI
To avoid conflict, I reverted changes in the exe file and I'm going to open another PR to update the assembly after this merged.

Finally! @yaira2 Ready for review.

[hishitetsu]

LGTM