Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Catch COMException wherever it occurs in shell extension loading #11411

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Details

  • COMException is now caught wherever it occurs in shell extension loading. In this case, the context menu will appear without the shell extension.
  • GetContextMenuForFolder() has been removed as it does not seem to be called from anywhere.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

Is it just me or does the menu load faster now 🤔

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 22, 2023
@hishitetsu
Copy link
Member Author

Is it just me or does the menu load faster now 🤔

That's strange, because nothing should change unless COMException is thrown.

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

Maybe a placebo but what matters is that it's working a lot better now.

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit 1d641ba into files-community:main Feb 22, 2023
@hishitetsu hishitetsu deleted the FollowUpCOMException branch February 22, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants