Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Xaml Styler GitHub Action #11379

Merged
merged 37 commits into from
Apr 3, 2023

Conversation

heftymouse
Copy link
Contributor

This will have to be added as a separate pipeline in the ADO portal. This was done to make it clearer what exactly is failing without having to look at logs.

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member

yaira2 commented Feb 20, 2023

Can we do a GitHub action?

@heftymouse
Copy link
Contributor Author

That can certainly be done

@heftymouse heftymouse marked this pull request as draft February 20, 2023 14:50
@heftymouse heftymouse changed the title Feature: Add Xaml Styler Azure Pipeline Feature: Add Xaml Styler GitHub Action Feb 20, 2023
@0x5bfa
Copy link
Member

0x5bfa commented Feb 20, 2023

Maybe Files pipelines should be split for specific functions. And inject all into job group. This files that you added doesn't work properly because Yair don't configure that yml file as Azure Pipeline yet.

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

@heftymouse are you still working on this?

@heftymouse
Copy link
Contributor Author

I'm still working on this, apologies for the delay

@heftymouse heftymouse marked this pull request as ready for review April 2, 2023 12:46
@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

@heftymouse do I need to do anything to activate the action?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 2, 2023
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It was a great job, looking commit messages😄

@yaira2 yaira2 merged commit a4641ff into files-community:main Apr 3, 2023
@heftymouse heftymouse deleted the pipelines branch October 31, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Xaml Styler step to devops pipeline
3 participants