Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where online-only files deleted before confirmation #11335

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
Online-only files cannot be tried for deletion probably because of Vanara or Win32 API, so they are treated as to be permanently deleted.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 17, 2023
@yaira2 yaira2 merged commit aaeb7b0 into files-community:main Feb 17, 2023
@hishitetsu hishitetsu deleted the DeleteOnlineFile branch February 17, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Deleting online-only files from OneDrive removes files regardless of the confirmation prompt
2 participants