Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show the "send to" option in the main menu #11329

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023

Looks like I need to add an even larger delay between tests in the CI.

@yaira2 yaira2 changed the title Feature: Add send to in main menu Feature: Show the "send to" option in the main menu Feb 16, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023

Can you apply this to the recent files widget?

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Feb 17, 2023
@hecksmosis
Copy link
Contributor Author

@yaira2 Added it to recent items

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2023

uE17D looked a little better imo

@hecksmosis
Copy link
Contributor Author

It looked a bit off to have both icons being the same in Recent Files

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2023

Isn't it a little different?

@hecksmosis
Copy link
Contributor Author

It doesn't have the color, the glyph is exactly the same as the one used for "Open with" while it's loading

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2023

Let's leave the icon blank for now until we can create our own.

@hecksmosis
Copy link
Contributor Author

Ok

@hecksmosis
Copy link
Contributor Author

Done

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Feb 17, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 17, 2023
@yaira2 yaira2 merged commit cda8b99 into files-community:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Show "send to" in the main context menu
2 participants