Feature: Add invalid tag name warning

[heftymouse]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Warn the user about invalid tag name #11293

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

[heftymouse]

Narrator doesn't read the text but I'm not sure how to solve it

[yaira2]

Narrator doesn't read the text but I'm not sure how to solve it

There is a setting to read it but I think it's okay as long as the text property is it.

[yaira2]

@heftymouse the tag settings were moved to a separate page

[heftymouse]

Sure, I can do that

…

On Fri, Feb 17, 2023, 11:03 PM Yair ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Files.App/Views/SettingsPages/Tags.xaml <#11324 (comment)> : > @@ -106,6 +106,40 @@ HorizontalAlignment="Right" Orientation="Horizontal" Spacing="12"> + <!-- Invalid Name Warning --> + <Grid I'll find the resource for it, can you switch to it? — Reply to this email directly, view it on GitHub <#11324 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOJEU7RLPJGBR4A7MF5LLLDWX6Y77ANCNFSM6AAAAAAU6DDIMY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[ferrariofilippo]

Can you solve the UX issue?

[QuaintMako]

It would be nice to have a tooltip when hovering on the "Invalid Name" telling what are the rules of naming a tag? Plus, having just the shortcut to cancel the edit in the tooltip is a bit weird.

[heftymouse]

Good idea, I'll do that
However the Esc tooltip is there for all the elements in the editing UI because of the keyboard accelerator lol

[yaira2]

This has been fixed, I'll fix the conflicts when it needs to be merged

Which resource was it?

[heftymouse]

Which resource was it?

I had to retemplate the control to centre align its content

[yaira2]

I had to retemplate the control to centre align its content

I was hoping we could do it with a single resource, if we have to restyle the whole control, it makes me wonder if the original implementation with a grid was cleaner. What are your thoughts on this?

[heftymouse]

I agree

[yaira2]

Can you fix the merge conflicts?

[yaira2]

Can you share a screenshot?

[heftymouse]

[yaira2]

LGTM

[yaira2]

@heftymouse can you fix the merge conflict?

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ferrariofilippo]

There's an issue where you can rename a tag using the name of an existing tag (but you cannot create it)

Just found another issue:
if you clear the tag name and hit Enter the name will be set to an empty string (still the warning is displayed correctly)

[ferrariofilippo]

LGTM