Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed closing app when the item flyout is open to hang #11310

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Feb 15, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
For some reason, the application does not close properly when a CommandBarFlyout is open, so the open flyout is forced to close before closing app, and then the application is closed as the event after closing the flyout.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 requested a review from QuaintMako February 15, 2023 15:14
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 15, 2023
@yaira2 yaira2 merged commit 5ff230b into files-community:main Feb 15, 2023
@hishitetsu hishitetsu deleted the FixAppCloseHang branch February 15, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Closing app when menu flyouts are open causes hang
2 participants